refactor: simplify Repository and Serde traits, introduce AnyRepository, remove ProtobufSerde #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ar3s3ru
commented
Dec 11, 2023
ar3s3ru
commented
- feat(aggregate::repository): expose single Repository trait, add AnyRepository extension
- refactor: use new Repository unified trait, switch to AnyRepository in examples
- refactor(serde): unify the Serde trait, remove serde-protobuf feature
- refactor(eventually): move to nested, local mod.rs pattern
…epository extension
ar3s3ru
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 87.33% 91.53% +4.19%
==========================================
Files 17 17
Lines 1161 1158 -3
==========================================
+ Hits 1014 1060 +46
+ Misses 147 98 -49 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.